[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patches] Fix posix/globtest.sh handling of HOME



posix/globtest.sh now includes a test involving setting HOME when running 
a test program.  This causes problems in cross testing, since HOME is 
generally blacklisted (e.g. in cross-test-ssh.sh) as unsuitable to carry 
to a different system verbatim.  Thus, I've changed the test to set HOME 
with "env" - on the remote system, in the case of cross testing - to avoid 
this blacklist.  To do so, ${run_program_prefix} needed expanding in this 
particular case to insert the "env" command in the middle.  Committed to 
trunk and 2.8 branch.

Index: posix/globtest.sh
===================================================================
--- posix/globtest.sh	(revision 6178)
+++ posix/globtest.sh	(working copy)
@@ -746,8 +746,9 @@
 `dir6/fil*[a'
 `nondir\/'
 EOF
-HOME="$testdir" \
-${run_program_prefix} \
+${cross_test_wrapper} \
+env HOME="$testdir" \
+${elf_objpfx}${rtld_installed_name} --library-path ${library_path} \
 ${common_objpfx}posix/globtest -ct "$testdir" \
 '~/dir1/file1_1' '~/dir1/file1_9' '~/dir3\*/file1' '~/dir3\*/file2' \
 '~\/dir1/file1_2' |
Index: ChangeLog.eglibc
===================================================================
--- ChangeLog.eglibc	(revision 6178)
+++ ChangeLog.eglibc	(working copy)
@@ -1,3 +1,7 @@
+2008-05-15  Joseph Myers  <joseph@xxxxxxxxxxxxxxxx>
+
+	* posix/globtest.sh: Set HOME with env on test target system.
+
 2008-05-14  Joseph Myers  <joseph@xxxxxxxxxxxxxxxx>
 
 	* iconvdata/Makefile (bug-iconv6-ENV, tst-iconv7-ENV): Define.

-- 
Joseph S. Myers
joseph@xxxxxxxxxxxxxxxx