[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patches] [PATCH] Fix EGLIBC build with -Os



On Sun, 7 Sep 2008, Aurelien Jarno wrote:

> EGLIBC (and GLIBC) currently fails to build with -Os, because some
> functions like fstatat64() are not inlined. This results in a failure
> are link time, as those functions are only available statically in 
> libc_nonshared.a.
> 
> When linking against libc.so, the /usr/lib/libc.so helper scripts takes
> care of linking with this static library. In order to build libc.so with
> -Os, it is also needed to link with libc_nonshared.a. That's the purpose
> of the patch below.

I don't believe linking against libc_nonshared.a is correct here; instead, 
the functions should be inlined.  Why isn't Sandra's patch 
<http://www.eglibc.org/archives/patches/msg00407.html> (in current EGLIBC 
versions) working for you here?  Is __USE_EXTERN_INLINES_IN_LIBC not being 
defined, or is the compiler not inlining some of the extern inline 
functions (which sounds like a compiler bug for these particular 
functions)?

-- 
Joseph S. Myers
joseph@xxxxxxxxxxxxxxxx