[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patches] Re: eglibc-2.8 fails to link with OPTION_EGLIBC_LOCAL_CODE=n
- To: Maxim Kuvyrkov <maxim@xxxxxxxxxxxxxxxx>
- Subject: Re: [patches] Re: eglibc-2.8 fails to link with OPTION_EGLIBC_LOCAL_CODE=n
- From: "Joseph S. Myers" <joseph@xxxxxxxxxxxxxxxx>
- Date: Mon, 24 Nov 2008 14:11:46 +0000 (UTC)
On Mon, 24 Nov 2008, Maxim Kuvyrkov wrote:
> The patch seems fine, modulo missing changelog entry and formatting (see
> below). I've tested the patch on powerpc-linux-gnu with no unexpected
> failures. There are two iconvdata tests (iconvdata/bug-iconv6.out and
> iconvdata/tst-iconv7.out) that use UTF-8 locale, and, hence, need conditioning
> on OPTION_EGLIBC_LOCALES_CODE; I'll post a separate patch to fix those.
>
> Joseph, can you review/approve this patch?
It seems reasonable to me.
--
Joseph S. Myers
joseph@xxxxxxxxxxxxxxxx