Re: [patches] [patch] Add BIG_MACROS option group

[Maxim Kuvyrkov <maxim@xxxxxxxxxxxxxxxx>]

Joseph S. Myers wrote:
> On Wed, 22 Jul 2009, Maxim Kuvyrkov wrote:
>
> > Hello,
> >
> > The attached patch adds new option group -- OPTION_EGLIBC_BIG_MACROS -- to
> > EGLIBC.  This option group does not enable or disable functionality, but
> > rather specifies if certain pieces of code should expand inline (through
> > macros) or use function calls instead.
> >
> > This particular patch handles __libc_lock_* macros which tend to expand to
> > rather significant portions of code (usually, around 0.5KB per instance).  For
> > example, on PowerPC wrapping this code into internal functions yields 1.5%
> > smaller libc.so.
> >
> > The patch describes a rather automatic way of converting such macros into
> > functions, so it will be easy to use it as a reference for future similar
> > conversions.
> >
> > Tested by build on powerpc in default and uClibc configurations.
> >
> > OK to apply?
>
> OK if you verify that the default configuration generates the same code as 
> without the patch applied, and that the test results are identical for two 
> configurations differing only in the setting of this option.

Verified on i686-linux-gnu build.

I've checked in the patch with a small change that makes an implicit 
dependency of bits/libc-locks.h on errno.h explicit.  This dependency 
indicated itself in failure during i686 build.

Thanks,

--
Maxim