[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patches] Allow ports to define the version of libgcc_s



On Mon, 17 Aug 2009, Maxim Kuvyrkov wrote:

> Hello,
> 
> The attached patch makes another attempt on GLIBC's PR4457
> (http://sourceware.org/bugzilla/show_bug.cgi?id=4457).
> 
> This patch is not exactly what Ulrich proposed to do about the issue; it
> doesn't detects the version of libgcc_s.so installed, but rather relies on
> shlib-versions files to specify it.  The entry in top-level shlib-versions
> file specifies the version of libgcc_s to be '1' (what most architectures
> have) and shlib-versions in sysdeps directories can override that.  This patch
> sets libgcc_s' version to 2 for m68k and hppa architectures.
> 
> FWIW, making GLIBC to autodetect the version of libgcc_s installed does not
> seem trivial to me.
> 
> OK for trunk and 2.10 branch given that this doesn't break build on ppc and
> m68k?

This is OK with the correction for hppa noted by Carlos, though I also 
encourage reopening that FSF PR and attaching a version of the libc 
changes, diffed against FSF GLIBC git, to it.

-- 
Joseph S. Myers
joseph@xxxxxxxxxxxxxxxx