Re: [patches] Redefine __i686

[Khem Raj <raj.khem@xxxxxxxxx>]

On Tue, Aug 9, 2011 at 2:09 PM, Joseph S. Myers <joseph@xxxxxxxxxxxxxxxx> wrote:
> On Tue, 9 Aug 2011, Khem Raj wrote:
>
>> Hi
>>
>> Attached patch is needed to fix a build failure when building eglibc
>> cross with x86_64 compiler with gcc -m32 switch and target is i686-*-*
>>
>> ChangeLog.eglibc
>>
>> 2011-08-09  Khem Raj  <raj.khem@xxxxxxxxx>
>>
>>         * sysdeps/generic/initfini.c: Re-define __i686.
>
> Why does this cause a failure now when previously your patch
>
> 2007-02-15  Khem Raj  <kraj@xxxxxxxxxx>
>
>        * sysdeps/unix/sysv/linux/i386/sysdep.h: Re-define __i686.
>        * nptl/sysdeps/pthread/pt-initfini.c: Ditto.
>
> sufficed to avoid such problems?  What has changed to require such a patch
> in another place?

I think this file should have been patched as well along with that
patch back then
if we configure eglibc with --target=i686-linux-gnu the build failure
happens in current sources


>
> --
> Joseph S. Myers
> joseph@xxxxxxxxxxxxxxxx
>