[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patches] Getting LinuxThreads to work with EGLIBC 2.5 (part 2)



Joseph S. Myers wrote:
> On Thu, 22 Feb 2007, Richard Sandiford wrote:
> 
>> Still, it's better to be on the safe side.  I think reverting
>> is the best thing to do.
> 
> The non-TLS version is *identical* to the old glibc code in EGLIBC 2.3.  
> The TLS version is *identical* to the new version on glibc HEAD.  I fail 
> to see how the concept of having both those versions in the same file with 
> #ifdef is significant enough to need an assignment.

If that's the case, then I agree that this change must be OK.  However,
I think the ChangeLog entry should include:

  which is a partial reversion of:
  <Header for Change Reverted>

So that this is clear.

Richard, I'm sorry for the back-and-fro on this.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@xxxxxxxxxxxxxxxx
(650) 331-3385 x713