[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patches] Make --disable-versioning work in EGLIBC



On Thu, 7 May 2009, Maxim Kuvyrkov wrote:

> Index: glibc-trunk-2/extra-lib.mk
> ===================================================================
> --- glibc-trunk-2/extra-lib.mk	(revision 8413)
> +++ glibc-trunk-2/extra-lib.mk	(working copy)
> @@ -45,8 +45,11 @@ alltypes-$(lib) := $(foreach o,$(object-
>  ifeq (,$(filter $(lib),$(extra-libs-others)))
>  lib-noranlib: $(alltypes-$(lib))
>  ifeq (yes,$(build-shared))
> +# Build shared library only if there're routines to include.
> +ifneq (,$(filter-out $($(lib)-static-only-routines),$(all-$(lib)-routines)))
>  lib-noranlib: $(objpfx)$(lib).so$($(lib).so-version)
>  endif
> +endif

What is this change for, and how can we be confident it will never affect 
the versioning-enabled case?  (The other changes look OK in that regard.)

-- 
Joseph S. Myers
joseph@xxxxxxxxxxxxxxxx