Joseph S. Myers wrote:
On Thu, 7 May 2009, Maxim Kuvyrkov wrote:Index: glibc-trunk-2/extra-lib.mk =================================================================== --- glibc-trunk-2/extra-lib.mk (revision 8413) +++ glibc-trunk-2/extra-lib.mk (working copy) @@ -45,8 +45,11 @@ alltypes-$(lib) := $(foreach o,$(object- ifeq (,$(filter $(lib),$(extra-libs-others))) lib-noranlib: $(alltypes-$(lib)) ifeq (yes,$(build-shared)) +# Build shared library only if there're routines to include. +ifneq (,$(filter-out $($(lib)-static-only-routines),$(all-$(lib)-routines))) lib-noranlib: $(objpfx)$(lib).so$($(lib).so-version) endif +endifWhat is this change for, and how can we be confident it will never affect the versioning-enabled case? (The other changes look OK in that regard.)
Originally this piece was used because lib-noranlib target failed to make for no good reason when using --disable-versioning.
However now, this appears to be an artifact of iterative testing and fixing bugs; this hunk doesn't affect the patch anymore (verified on arm and x86; mips and power are in progress). If the builds finish fine, I'll simply remove the hunk.
Thanks, -- Maxim