[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patches] Use a compile-time test for -fstack-protector



On Wed, 11 Nov 2009, Thomas Schwinge wrote:

> Hello!
> 
> On 2009-11-11 01:17, Joseph S. Myers wrote:
> > On Sun, 8 Nov 2009, Thomas Schwinge wrote:
> >
> >>  if AC_TRY_COMMAND([${CC-cc} $CFLAGS $CPPFLAGS $LDFLAGS -Werror -fstack-protector
> >> -			    -o conftest conftest.c 1>&AS_MESSAGE_LOG_FD])
> >> +			    -o /dev/null -c -x c /dev/null 1>&AS_MESSAGE_LOG_FD])
> >
> > Does this still work if you remove $LDFLAGS from the compilation line?  
> 
> Sorry, I simply forgot to remove them.  LDFLAGS are indeed not needed
> here (and should usually be empty, anyway).
> 
> 
> 2009-11-11  Thomas Schwinge  <thomas@xxxxxxxxxxxxxxxx>
> 
> 	* configure.in (libc_cv_ssp): Make this a compile-time check.  Avoid
> 	creating temporary files.

Thanks, I've committed this revised patch.

-- 
Joseph S. Myers
joseph@xxxxxxxxxxxxxxxx