[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patches] Implement new EGLIBC_NSCD option group.



On Tue, Mar 1, 2011 at 2:03 AM, Joseph S. Myers <joseph@xxxxxxxxxxxxxxxx> wrote:
> (Thus, one question about testing would be how it was verified that with
> the option group in its default state - enabled - nscd still builds and
> libc still works with the nscd.)

It's verified that nscd is built by the mere evidence that it's
built...  The resulted EGLIBC is tested and used and is fine.  But
I've never used the nscd itself, instead I've been trying to exclude
it all the way.  So I can't say does nscd work or doesn't either with
or without my patch.  But the patch nearly doesn't touch the code, it
just plays with the USE_NSCD macro, which is already in the code.  The
patch just adds the ability to turn the macro on or off.  And where
the code is touched by the patch, the changes are just trivial - there
are just a conditionings.

Then, the play with USE_NSCD is almost a kind of a rewrite of
OPTION_EGLIBC_INET's usage, and this option should already be tested.

So, I think the patch is safe.