Re: [patches] Implement new EGLIBC_NSCD option group.

["Joseph S. Myers" <joseph@xxxxxxxxxxxxxxxx>]

On Mon, 28 Feb 2011, Maxim Kuvyrkov wrote:

> On Feb 27, 2011, at 3:46 PM, Denis Zaitceff wrote:
> 
> > This option group is for exclude NSCD code from EGLIBC.  As for now, 
> > NSCD depends on EGLIBC_INET group, and with the new option group NSCD 
> > can be excluded while all the remain INET group is stay included.
> 
> Looks very good, thank you for the patch.  What testing (architecture, 
> build/testsuite runs) has this patch had?
> 
> Joseph, do you have any comments on this patch?

My technical comments would be:

* We don't generally condition things in Versions files on option groups.

* If you have an option group conditional in a .c or .h file, you need to 
include <gnu/option-groups.h> there; it won't generally be included 
implicitly.

(Thus, one question about testing would be how it was verified that with 
the option group in its default state - enabled - nscd still builds and 
libc still works with the nscd.)

-- 
Joseph S. Myers
joseph@xxxxxxxxxxxxxxxx