[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Patches] manual/Makefile: fix escaping of PKGVERSION and REPORT_BUGS_TO
- To: Michael Hope <michael.hope@xxxxxxxxxx>
- Subject: Re: [Patches] manual/Makefile: fix escaping of PKGVERSION and REPORT_BUGS_TO
- From: Maxim Kuvyrkov <maxim@xxxxxxxxxxxxxxxx>
- Date: Tue, 11 Oct 2011 17:24:21 +1300
On 10/10/2011, at 9:00 AM, Michael Hope wrote:
> crosstool-NG uses 'crosstool-NG @ mercurial-revno' as the default
> package version. This breaks the EGLIBC manuals as '@' starts a
> Texinfo command. Fix by escaping.
>
> I noticed that REPORT_BUGS_TO is broken as well, but in a different
> way. There's a sed that converts @ into the escaped @@ to allow email
> style bug URLs, but it applies it to the command as well as the value.
>
> I've converted these to GNU make substitutions instead. The change is EGLIBC
> specific as GLIBC doesn't put the pkgversion in the manual.
Michael,
Yeap, you are right, I will check in your patch shortly.
It should fix the overly pessimistic beginning of EGLIBC docs [*] :-).
[*] https://sourcery.mentor.com/GNUToolchain/doc12125/libc.pdf
Thanks for fixing this,
--
Maxim Kuvyrkov
CodeSourcery / Mentor Graphics