[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Patches] manual/Makefile: fix escaping of PKGVERSION and REPORT_BUGS_TO



On Mon, 10 Oct 2011, Michael Hope wrote:

> crosstool-NG uses 'crosstool-NG @ mercurial-revno' as the default
> package version.  This breaks the EGLIBC manuals as '@' starts a
> Texinfo command.  Fix by escaping.
> 
> I noticed that REPORT_BUGS_TO is broken as well, but in a different
> way.  There's a sed that converts @ into the escaped @@ to allow email
> style bug URLs, but it applies it to the command as well as the value.
> 
> I've converted these to GNU make substitutions instead.  The change is EGLIBC
> specific as GLIBC doesn't put the pkgversion in the manual.

I see Maxim committed this, but I don't think it's the right approach.  
The autoconf macros used (shared with GCC, binutils etc.) define 
REPORT_BUGS_TEXI, and that's what should be used for the manual.

-- 
Joseph S. Myers
joseph@xxxxxxxxxxxxxxxx