Re: [Patches] int/hex/string option types

[Steve Longerbeam <steve_longerbeam@xxxxxxxxxx>]

On 11/28/2011 03:56 PM, Steve Longerbeam wrote:
> This patch builds on the menuconfig patch for EGLIBC.
>
> There are a few options that have non-boolean types, that would 
> benefit from the new 'make *config' support:
>
> EGLIBC_MEMUSAGE_DEFAULT_BUFFER_SIZE (int)
> EGLIBC_NSSWITCH_FIXED_CONFIG (string)
> EGLIBC_NSSWITCH_FIXED_FUNCTIONS (string)
>
> The patch converts these to real options in libc/option-groups.def. 
> Also, libc/scripts/option-groups.awk is modified to output a '#define' 
> line for int, hex, or string options encountered in the config file.
>
> In the post-processing script config-postproc.pl, a small change is 
> needed: for any boolean option FOO that is implicitly disabled in the 
> kconfig output, make sure that option is indeed a boolean before 
> printing the explicit OPTION_FOO=n.

found a small bug in config-postproc.pl, patch against 
eglibc-menuconfig-nonbool.patch is attached.

Thanks,

--
Steve Longerbeam | Senior Embedded Engineer, ESD Services
Mentor Embedded(tm) | 46871 Bayside Parkway, Fremont, CA 94538
P 510.354.5838 | M 408.410.2735
Nucleus(r) | Linux(r) | Android(tm) | Services | UI | Multi-OS

diff -u eglibc/libc/options-config/config-postproc.pl eglibc/libc/options-config/config-postproc.pl
--- eglibc/libc/options-config/config-postproc.pl	2011-11-23 15:01:04.877717837 -0800
+++ eglibc/libc/options-config/config-postproc.pl	2011-11-30 16:18:47.400933191 -0800
@@ -8,7 +8,7 @@
 die "Could not open $ARGV[0]" unless -T $ARGV[0];
 
 sub yank {
-    @option = grep(!($_ =~ /$_[0]/), @option);
+    @option = grep(!($_ =~ /$_[0]\s*=/), @option);
 }
 
 open(DEFAULTS, $defaults) || die "Could not open $defaults\n";

_______________________________________________
Patches mailing list
Patches@xxxxxxxxxx
http://eglibc.org/cgi-bin/mailman/listinfo/patches