[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Patches] menuconfig for EGLIBC

Only a couple of comments on this patch:

In config-postproc.pl you call a subroutine with leading '&', but man 
perlstyle advises "Call your subroutines as if they were functions or list 
operators to avoid excessive ampersands and parentheses." - it's rarely 
necessary to use the '&' in modern perl (as I recall, it was perl 4 that 
required it).

It appears to be usual for makefiles to call perl scripts using $(PERL) 
rather than directly.

-- 
Joseph S. Myers
joseph@xxxxxxxxxxxxxxxx
_______________________________________________
Patches mailing list
Patches@xxxxxxxxxx
http://eglibc.org/cgi-bin/mailman/listinfo/patches